[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <58722a65-87ad-458c-9bf0-01c0627f4cb7@iogearbox.net>
Date: Fri, 4 Oct 2024 11:27:52 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: martin.lau@...ux.dev, razor@...ckwall.org, jrife@...gle.com,
tangchen.1@...edance.com, bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next 2/4] netkit: Add add netkit scrub support to
rt_link.yaml
On 10/4/24 12:18 AM, Jakub Kicinski wrote:
> On Thu, 3 Oct 2024 20:03:18 +0200 Daniel Borkmann wrote:
>> + -
>> + name: netkit-scrub
>> + type: enum
>> + entries:
>> + - name: none
>> + - name: default
>
> The behavior of the scrub should probably be documented somewhere
> (either here or in the if_link.h header?)
> What the "default" is may not be obvious to a newcomer?
> Perhaps you plan to document it in the man page, but dunno if
> programmers using netlink directly will check there.
Makes sense, I'll add a description to the if_link.h uapi header.
Powered by blists - more mailing lists