netdev - Re: [PATCH bpf-next v2 2/5] netkit: Simplify netkit mode over to use NLA_POLICY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99f316d5-72a6-40d9-9803-c51180df4674@blackwall.org>
Date: Sat, 5 Oct 2024 16:38:30 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Daniel Borkmann <daniel@...earbox.net>, martin.lau@...ux.dev
Cc: kuba@...nel.org, jrife@...gle.com, tangchen.1@...edance.com,
 bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 2/5] netkit: Simplify netkit mode over to use
 NLA_POLICY_MAX

On 04/10/2024 13:13, Daniel Borkmann wrote:
> Jakub suggested to rely on netlink policy validation via NLA_POLICY_MAX()
> instead of open-coding it. netkit_check_mode() is a candidate which can
> be simplified through this as well aside from the netkit scrubbing one.
> 
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Cc: Nikolay Aleksandrov <razor@...ckwall.org>
> ---
>  v1 -> v2:
>    - new patch, also use NLA_POLICY_MAX here (Jakub)
> 
>  drivers/net/netkit.c | 25 +++----------------------
>  1 file changed, 3 insertions(+), 22 deletions(-)
> 

Nice :)
Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>