netdev - Re: [PATCH net-next v2] tcp: remove unnecessary update for tp->write_seq in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADVnQymUCp1nocPYUCXx1QmN4Y8ABJMd0urJeB5_J=TL8b7_Yg@mail.gmail.com>
Date: Sat, 5 Oct 2024 13:40:15 -0400
From: Neal Cardwell <ncardwell@...gle.com>
To: "xin.guo" <guoxin0309@...il.com>
Cc: edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] tcp: remove unnecessary update for
 tp->write_seq in tcp_connect()

On Sat, Oct 5, 2024 at 11:58 AM xin.guo <guoxin0309@...il.com> wrote:
>
> From: "xin.guo" <guoxin0309@...il.com>
>
> Commit 783237e8daf13("net-tcp: Fast Open client - sending SYN-data")

To match Linux commit message style, please insert a space between the
SHA1 and the patch title, like so:

Commit 783237e8daf13 ("net-tcp: Fast Open client - sending SYN-data")

> introduces tcp_connect_queue_skb() and it would overwrite tcp->write_seq,
> so it is no need to update tp->write_seq before invoking
> tcp_connect_queue_skb()
>
> Signed-off-by: xin.guo <guoxin0309@...il.com>
> ---
>  net/ipv4/tcp_output.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 4fd746b..ee8ab9a 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -4134,7 +4134,10 @@ int tcp_connect(struct sock *sk)
>         if (unlikely(!buff))
>                 return -ENOBUFS;
>
> -       tcp_init_nondata_skb(buff, tp->write_seq++, TCPHDR_SYN);
> +       /*SYN eats a sequence byte, write_seq updated by
> +        *tcp_connect_queue_skb().
> +        */
> +       tcp_init_nondata_skb(buff, tp->write_seq, TCPHDR_SYN);
>         tcp_mstamp_refresh(tp);
>         tp->retrans_stamp = tcp_time_stamp_ts(tp);
>         tcp_connect_queue_skb(sk, buff);
> --

As in the example provided by Eric, please use Linux kernel C comment
style, which places a space character between the * and the first
character of the comment text on each line. For example:

/* SYN eats a sequence byte, write_seq is updated by
 * tcp_connect_queue_skb().
 */

For more information, see:

https://www.kernel.org/doc/html/v6.11/process/coding-style.html#commenting

thanks,
neal