netdev - Re: [PATCH v2] net: fix register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ebce461-e4eb-4f10-9de8-19240193b262@gmail.com>
Date: Mon, 7 Oct 2024 01:00:19 +0300
From: Ivan Safonov <insafonov@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Jiri Pirko <jiri@...nulli.us>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Lorenzo Bianconi <lorenzo@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: fix register_netdev description

On 10/7/24 00:16, Andrew Lunn wrote:
> On Sun, Oct 06, 2024 at 08:57:20PM +0300, Ivan Safonov wrote:
>> register_netdev() does not expands the device name.
> 
> Please could you explain what makes you think it will not expand the
> device name.
> 
> 	Andrew

It is the register_netdev implementation:

> int register_netdev(struct net_device *dev)
> {
> 	int err;
> 
> 	if (rtnl_lock_killable())
> 		return -EINTR;
> 	err = register_netdevice(dev);
> 	rtnl_unlock();
> 	return err;
> }

There is no device name expansion, rtnl lock and register_netdevice call 
only. The register_netdevice expands device name using dev_get_valid_name().