[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241006064747.201773-1-gnaaman@drivenets.com>
Date: Sun, 6 Oct 2024 06:47:41 +0000
From: Gilad Naaman <gnaaman@...venets.com>
To: netdev <netdev@...r.kernel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>
Cc: Gilad Naaman <gnaaman@...venets.com>
Subject: [PATCH net-next v2 0/2] Improve neigh_flush_dev performance
This patchsets improves the performance of neigh_flush_dev.
Currently, the only way to implement it requires traversing
all neighbours known to the kernel, across all network-namespaces.
This means that some flows are slowed down as a function of neighbour-scale,
even if the specific link they're handling has little to no neighbours.
In order to solve this, this patchset adds a netdev->neighbours list,
as well as making the original linked-list doubly-, so that it is
possible to unlink neighbours without traversing the hash-bucket to
obtain the previous neighbour.
The original use-case we encountered was mass-deletion of links (12K
VLANs) while there are 50K ARPs and 50K NDPs in the system; though the
slowdowns would also appear when the links are set down.
Changes in v2:
- Fix RCU usage
- Document new net_device->neighbours field
Gilad Naaman (2):
Convert neighbour-table to use hlist
Create netdev->neighbour association
.../networking/net_cachelines/net_device.rst | 1 +
include/linux/netdevice.h | 6 +
include/net/neighbour.h | 18 +-
include/net/neighbour_tables.h | 13 +
net/core/neighbour.c | 224 +++++++++---------
5 files changed, 144 insertions(+), 118 deletions(-)
create mode 100644 include/net/neighbour_tables.h
--
2.46.0
Powered by blists - more mailing lists