netdev - Re: [PATCH net-next v2 1/2] Convert neighbour-table to use hlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241006155645.58445-1-kuniyu@amazon.com>
Date: Sun, 6 Oct 2024 08:56:45 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <gnaaman@...venets.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH net-next v2 1/2] Convert neighbour-table to use hlist

From: Gilad Naaman <gnaaman@...venets.com>
Date: Sun,  6 Oct 2024 06:47:42 +0000
> @@ -2728,9 +2695,7 @@ static int neigh_dump_table(struct neigh_table *tbl, struct sk_buff *skb,
>  	for (h = s_h; h < (1 << nht->hash_shift); h++) {
>  		if (h > s_h)
>  			s_idx = 0;
> -		for (n = rcu_dereference(nht->hash_buckets[h]), idx = 0;
> -		     n != NULL;
> -		     n = rcu_dereference(n->next)) {
> +		hlist_for_each_entry_rcu(n, &nht->hash_buckets[h], list) {

idx = 0 was accidentally removed.


>  			if (idx < s_idx || !net_eq(dev_net(n->dev), net))
>  				goto next;
>  			if (neigh_ifindex_filtered(n->dev, filter->dev_idx) ||