netdev - Re: [PATCH v8 net-next 00/15] net: introduce TX H/W shaping API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwP8OWtMfCH0_ikc@nanopsycho.orion>
Date: Mon, 7 Oct 2024 17:20:25 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
	Madhu Chittim <madhu.chittim@...el.com>,
	Sridhar Samudrala <sridhar.samudrala@...el.com>,
	Simon Horman <horms@...nel.org>,
	John Fastabend <john.fastabend@...il.com>,
	Sunil Kovvuri Goutham <sgoutham@...vell.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Donald Hunter <donald.hunter@...il.com>, anthony.l.nguyen@...el.com,
	przemyslaw.kitszel@...el.com, intel-wired-lan@...ts.osuosl.org,
	edumazet@...gle.com, Stanislav Fomichev <stfomichev@...il.com>
Subject: Re: [PATCH v8 net-next 00/15] net: introduce TX H/W shaping API

Mon, Sep 30, 2024 at 03:53:47PM CEST, pabeni@...hat.com wrote:
>We have a plurality of shaping-related drivers API, but none flexible
>enough to meet existing demand from vendors[1].
>
>This series introduces new device APIs to configure in a flexible way
>TX H/W shaping. The new functionalities are exposed via a newly
>defined generic netlink interface and include introspection
>capabilities. Some self-tests are included, on top of a dummy
>netdevsim implementation. Finally a basic implementation for the iavf
>driver is provided.
>

[...]


>---
>Changes from v7:
> - fixed uninit error and related ST failures
> - dev lock cleanup
> - fixed a bunch of typos


Was out of the loop for last couple of iterations for personal reasons,
sorry for getting to this after such while!

Overall, I like very much how the patchset looks right now. I reviewed
it, didn't find anything noteworthy.

set-
Reviewed-by: Jiri Pirko <jiri@...dia.com>

Thanks for the work Paolo!

I will try to convert devlink rate to this api soon, I promise.