netdev - Re: [PATCH net-next v19 09/14] net: rename skb_copy_to_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKgT0Ue=tX+hKWiXQaM-6ypZ8fGvcUagGKfVrNGtRHVuhMX80g@mail.gmail.com>
Date: Mon, 7 Oct 2024 11:49:41 -0700
From: Alexander Duyck <alexander.duyck@...il.com>
To: Yunsheng Lin <yunshenglin0825@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Yunsheng Lin <linyunsheng@...wei.com>, Eric Dumazet <edumazet@...gle.com>, 
	David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net-next v19 09/14] net: rename skb_copy_to_page_nocache() helper

On Mon, Oct 7, 2024 at 7:29 AM Yunsheng Lin <yunshenglin0825@...il.com> wrote:
>
> On 10/7/2024 12:18 AM, Alexander Duyck wrote:
>
> ...
>
> >
> > I could probably live with sk_copy_to_skb_data_nocache since we also
> > refer to the section after the page section with data_len. The basic
> > idea is we are wanting to define what the function does with the
> > function name rather than just report the arguments it is accepting.
>
> Yes, looking more closely:
> skb_add_data_nocache() does memcpy'ing to skb->data and update skb->len
> only by calling skb_put(), and skb_copy_to_page_nocache() does
> memcpy'ing to skb frag by updating both skb->len and skb->data_len
> through the calling of skb_len_add().
>
> Perhaps skb_add_frag_nocache() might seems a better name for now, and
> the 'sk_' prefix might be done in the future if it does make sense.

That works for me.