netdev - RE: [PATCH net] net: ibm: emac: mal: add dcr_unmap to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB50892D82561D2A4308A7226FD67D2@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Mon, 7 Oct 2024 22:30:43 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Rosen Penev <rosenp@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "andrew@...n.ch" <andrew@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"horms@...nel.org" <horms@...nel.org>, "sd@...asysnail.net"
	<sd@...asysnail.net>, "chunkeey@...il.com" <chunkeey@...il.com>
Subject: RE: [PATCH net] net: ibm: emac: mal: add dcr_unmap to _remove



> -----Original Message-----
> From: Rosen Penev <rosenp@...il.com>
> Sent: Monday, October 7, 2024 1:39 PM
> To: netdev@...r.kernel.org
> Cc: andrew@...n.ch; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; linux-kernel@...r.kernel.org; Keller,
> Jacob E <jacob.e.keller@...el.com>; horms@...nel.org; sd@...asysnail.net;
> chunkeey@...il.com
> Subject: [PATCH net] net: ibm: emac: mal: add dcr_unmap to _remove
> 
> It's done in probe so it should be done in remove.
> 
> Fixes: 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling")
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  drivers/net/ethernet/ibm/emac/mal.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/ibm/emac/mal.c
> b/drivers/net/ethernet/ibm/emac/mal.c
> index 1e1860ddc363..b1a32070f03a 100644
> --- a/drivers/net/ethernet/ibm/emac/mal.c
> +++ b/drivers/net/ethernet/ibm/emac/mal.c
> @@ -715,6 +715,8 @@ static void mal_remove(struct platform_device *ofdev)
> 
>  	free_netdev(mal->dummy_dev);
> 
> +	dcr_unmap(mal->dcr_host, 0x100);
> +
>  	dma_free_coherent(&ofdev->dev,
>  			  sizeof(struct mal_descriptor) *
>  				  (NUM_TX_BUFF * mal->num_tx_chans +
> --
> 2.46.2

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>