netdev - Re: [PATCH net-next v3 2/5] eth: fbnic: add initial PHC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95fbd4ac-e7a3-4035-b78f-f71f06cbf519@intel.com>
Date: Mon, 7 Oct 2024 16:57:29 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Vadim Fedorenko
	<vadim.fedorenko@...ux.dev>
CC: Vadim Fedorenko <vadfed@...a.com>, David Ahern <dsahern@...nel.org>,
	"Paolo Abeni" <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>,
	"Alexander Duyck" <alexanderduyck@...com>, <netdev@...r.kernel.org>, Richard
 Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next v3 2/5] eth: fbnic: add initial PHC support



On 10/7/2024 4:09 PM, Jakub Kicinski wrote:
>>> I think another way to implement this is to read lo, then hi, then lo
>>> again, and if lo2 is smaller than lo, you know hi overflowed and you can
>>> re-read hi  
>>
>> That's an option too, I'll think of it, thanks!
> 
> The triple read is less neat in case hi jumps by more than 1.
> 

Wouldn't that require the lower bits to accumulate more than an entire
cycle for that to happen?