netdev - Re: [net-next] net: ravb: Only advertise Rx/Tx timestamps if hardware supports it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f95330ea-323e-4d41-a236-4e29aab0071b@bp.renesas.com>
Date: Mon, 7 Oct 2024 10:23:56 +0100
From: Paul Barker <paul.barker.ct@...renesas.com>
To: Niklas Söderlund
 <niklas.soderlund+renesas@...natech.se>, Sergey Shtylyov
 <s.shtylyov@....ru>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
 Biju Das <biju.das.jz@...renesas.com>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 netdev@...r.kernel.org
Cc: linux-renesas-soc@...r.kernel.org
Subject: Re: [net-next] net: ravb: Only advertise Rx/Tx timestamps if hardware
 supports it

On 05/10/2024 13:14, Niklas Söderlund wrote:
> Recent work moving the reporting of Rx software timestamps to the core
> [1] highlighted an issue where hardware time stamping where advertised
> for the platforms where it is not supported.
> 
> Fix this by covering advertising support for hardware timestamps only if
> the hardware supports it. Due to the Tx implementation in RAVB software
> Tx timestamping is also only considered if the hardware supports
> hardware timestamps. This should be addressed in future, but this fix
> only reflects what the driver currently implements.
> 
> 1. Commit 277901ee3a26 ("ravb: Remove setting of RX software timestamp")
> 
> Fixes: 7e09a052dc4e ("ravb: Exclude gPTP feature support for RZ/G2L")
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

On RZ/G2UL, which doesn't support HW timestamping, before this patch:

    $ ethtool -T eth0
    Time stamping parameters for eth0:
    Capabilities:
            hardware-transmit
            software-transmit
            hardware-receive
            software-receive
            software-system-clock
            hardware-raw-clock
    PTP Hardware Clock: 0
    Hardware Transmit Timestamp Modes:
            off
            on
    Hardware Receive Filter Modes:
            none
            all
            ptpv2-l2-event

After this patch:

    $ ethtool -T eth0
    Time stamping parameters for eth0:
    Capabilities:
            software-receive
            software-system-clock
    PTP Hardware Clock: none
    Hardware Transmit Timestamp Modes: none
    Hardware Receive Filter Modes: none

Thanks Niklas!

Reviewed-by: Paul Barker <paul.barker.ct@...renesas.com>
Tested-by: Paul Barker <paul.barker.ct@...renesas.com>

-- 
Paul Barker
Download attachment "OpenPGP_0x27F4B3459F002257.asc" of type "application/pgp-keys" (3521 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)