netdev - Re: [PATCH net-next] net: add kdoc for dev->fib_nh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iJ7ts91-pEqL3wAHAu9Cco6MDPZfr++fUjTUxY8Qu3L2w@mail.gmail.com>
Date: Tue, 8 Oct 2024 11:48:12 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com, 
	Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next] net: add kdoc for dev->fib_nh_head

On Tue, Oct 8, 2024 at 11:38 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> Simon reported that fib_nh_head kdoc was missing.
>
> Fixes: a3f5f4c2f9b6 ("ipv4: remove fib_info_devhash[]")
> Closes: https://lore.kernel.org/netdev/20241007140850.GC32733@kernel.org/raw
> Reported-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  include/linux/netdevice.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 3baf8e539b6f33caaf83961c4cf619b799e5e41d..b5a5a2b555cda76ce2c0b3b3b2124b34409d1d69 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1842,6 +1842,7 @@ enum netdev_reg_state {
>   *     @tipc_ptr:      TIPC specific data
>   *     @atalk_ptr:     AppleTalk link
>   *     @ip_ptr:        IPv4 specific data
> + *     @fib_nh_head:   list of fib_nh attached to this device
>   *     @ip6_ptr:       IPv6 specific data
>   *     @ax25_ptr:      AX.25 specific data
>   *     @ieee80211_ptr: IEEE 802.11 specific data, assign before registering
> --
> 2.47.0.rc0.187.ge670bccf7e-goog
>

Hmm... maybe not needed, I saw Jakub added inline:

/** @fib_nh_head: nexthops associated with this netdev */

Thanks !