netdev - Re: [PATCH v3 net-next 3/4] rtnetlink: Add assertion helpers for per-netns RTNL.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKcbZQhmTV2tbv-7u9WSg2rFkiMRWLieBz-a7c6xT1o5A@mail.gmail.com>
Date: Tue, 8 Oct 2024 13:46:50 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Kuniyuki Iwashima <kuniyu@...zon.com>, Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH v3 net-next 3/4] rtnetlink: Add assertion helpers for
 per-netns RTNL.

On Tue, Oct 8, 2024 at 1:39 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> Hi,
>
> On 10/5/24 00:10, Kuniyuki Iwashima wrote:
> > Once an RTNL scope is converted with rtnl_net_lock(), we will replace
> > RTNL helper functions inside the scope with the following per-netns
> > alternatives:
> >
> >    ASSERT_RTNL()           -> ASSERT_RTNL_NET(net)
> >    rcu_dereference_rtnl(p) -> rcu_dereference_rtnl_net(net, p)
> >
> > Note that the per-netns helpers are equivalent to the conventional
> > helpers unless CONFIG_DEBUG_NET_SMALL_RTNL is enabled.
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
>
> I guess Kuniyuki stripped the ack received on v2 due to the edit here.
>
> @Kuniyuki: in the next iterations, please include a per patch changelog
> to simplify the review.
>
> @Eric: would you mind acking it again? Thanks!

Let me check this new version :)