netdev - Re: [PATCH net-next] net_sched: sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87frp6u6u6.fsf@toke.dk>
Date: Tue, 08 Oct 2024 14:17:37 +0200
From: Toke Høiland-Jørgensen <toke@...hat.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>
Cc: Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang
 <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 netdev@...r.kernel.org, eric.dumazet@...il.com, Eric Dumazet
 <edumazet@...gle.com>
Subject: Re: [PATCH net-next] net_sched: sch_sfq: handle bigger packets

Eric Dumazet <edumazet@...gle.com> writes:

> SFQ has an assumption on dealing with packets smaller than 64KB.
>
> Even before BIG TCP, TCA_STAB can provide arbitrary big values
> in qdisc_pkt_len(skb)
>
> It is time to switch (struct sfq_slot)->allot to a 32bit field.
>
> sizeof(struct sfq_slot) is now 64 bytes, giving better cache locality.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Makes sense!

Reviewed-by: Toke Høiland-Jørgensen <toke@...hat.com>