[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <851ebd20-0f7a-438d-8035-366964d2c4d8@lunn.ch>
Date: Tue, 8 Oct 2024 15:08:32 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH v2] net: phy: Validate PHY LED OPs presence
before registering
> + /* Check if the PHY driver have at least an OP to
> + * set the LEDs.
> + */
> + if (!phydev->drv->led_brightness_set &&
> + !phydev->drv->led_blink_set &&
> + !phydev->drv->led_hw_control_set) {
I think this condition is too strong. All that should be required is
led_brightness_set(). The rest can be done in software.
Andrew
---
pw-bot: cr
Powered by blists - more mailing lists