netdev - Re: [PATCH V7 4/5] bnxt_en: Add TPH support in BNXT driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241008063959.0b073aab@kernel.org>
Date: Tue, 8 Oct 2024 06:39:59 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Wei Huang <wei.huang2@....com>
Cc: <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-doc@...r.kernel.org>, <netdev@...r.kernel.org>,
 <Jonathan.Cameron@...wei.com>, <helgaas@...nel.org>, <corbet@....net>,
 <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <alex.williamson@...hat.com>, <gospo@...adcom.com>,
 <michael.chan@...adcom.com>, <ajit.khaparde@...adcom.com>,
 <somnath.kotur@...adcom.com>, <andrew.gospodarek@...adcom.com>,
 <manoj.panicker2@....com>, <Eric.VanTassell@....com>,
 <vadim.fedorenko@...ux.dev>, <horms@...nel.org>, <bagasdotme@...il.com>,
 <bhelgaas@...gle.com>, <lukas@...ner.de>, <paul.e.luse@...el.com>,
 <jing2.liu@...el.com>
Subject: Re: [PATCH V7 4/5] bnxt_en: Add TPH support in BNXT driver

On Wed, 2 Oct 2024 11:59:53 -0500 Wei Huang wrote:
> +	if (netif_running(irq->bp->dev)) {
> +		rtnl_lock();
> +		err = netdev_rx_queue_restart(irq->bp->dev, irq->ring_nr);
> +		if (err)
> +			netdev_err(irq->bp->dev,
> +				   "rx queue restart failed: err=%d\n", err);
> +		rtnl_unlock();
> +	}
> +}
> +
> +static void __bnxt_irq_affinity_release(struct kref __always_unused *ref)
> +{
> +}

An empty release function is always a red flag.
How is the reference counting used here?
Is irq_set_affinity_notifier() not synchronous?
Otherwise the rtnl_lock() should probably cover the running check.