netdev - Re: [PATCH v3 net-next 3/4] rtnetlink: Add assertion helpers for per-netns RTNL.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241008161211.92974-1-kuniyu@amazon.com>
Date: Tue, 8 Oct 2024 09:12:11 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <pabeni@...hat.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net-next 3/4] rtnetlink: Add assertion helpers for per-netns RTNL.

From: Paolo Abeni <pabeni@...hat.com>
Date: Tue, 8 Oct 2024 13:39:24 +0200
> On 10/5/24 00:10, Kuniyuki Iwashima wrote:
> > Once an RTNL scope is converted with rtnl_net_lock(), we will replace
> > RTNL helper functions inside the scope with the following per-netns
> > alternatives:
> > 
> >    ASSERT_RTNL()           -> ASSERT_RTNL_NET(net)
> >    rcu_dereference_rtnl(p) -> rcu_dereference_rtnl_net(net, p)
> > 
> > Note that the per-netns helpers are equivalent to the conventional
> > helpers unless CONFIG_DEBUG_NET_SMALL_RTNL is enabled.
> > 
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> 
> I guess Kuniyuki stripped the ack received on v2 due to the edit here.
> 
> @Kuniyuki: in the next iterations, please include a per patch changelog 
> to simplify the review.

Sure, will include changelog per-patch basis for future submission.

Thanks!