netdev - Re: [PATCH bpf 2/4] selftests/bpf: Consolidate kernel modules into common directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwV3d5-sBYtgt2vi@krava>
Date: Tue, 8 Oct 2024 20:18:31 +0200
From: Jiri Olsa <olsajiri@...il.com>
To: Toke Høiland-Jørgensen <toke@...hat.com>
Cc: Jiri Olsa <olsajiri@...il.com>, Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	John Fastabend <john.fastabend@...il.com>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>,
	Kumar Kartikeya Dwivedi <memxor@...il.com>,
	Simon Sundberg <simon.sundberg@....se>, bpf@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH bpf 2/4] selftests/bpf: Consolidate kernel modules into
 common directory

On Tue, Oct 08, 2024 at 07:55:13PM +0200, Toke Høiland-Jørgensen wrote:
> Jiri Olsa <olsajiri@...il.com> writes:
> 
> > On Tue, Oct 08, 2024 at 12:35:17PM +0200, Toke Høiland-Jørgensen wrote:
> >
> > SNIP
> >
> >> diff --git a/tools/testing/selftests/bpf/bpf_testmod/.gitignore b/tools/testing/selftests/bpf/test_kmods/.gitignore
> >> similarity index 100%
> >> rename from tools/testing/selftests/bpf/bpf_testmod/.gitignore
> >> rename to tools/testing/selftests/bpf/test_kmods/.gitignore
> >> diff --git a/tools/testing/selftests/bpf/test_kmods/Makefile b/tools/testing/selftests/bpf/test_kmods/Makefile
> >> new file mode 100644
> >> index 0000000000000000000000000000000000000000..393f407f35baf7e2b657b5d7910a6ffdecb35910
> >> --- /dev/null
> >> +++ b/tools/testing/selftests/bpf/test_kmods/Makefile
> >> @@ -0,0 +1,25 @@
> >> +TEST_KMOD_DIR := $(realpath $(dir $(abspath $(lastword $(MAKEFILE_LIST)))))
> >> +KDIR ?= $(abspath $(TEST_KMOD_DIR)/../../../../..)
> >> +
> >> +ifeq ($(V),1)
> >> +Q =
> >> +else
> >> +Q = @
> >> +endif
> >> +
> >> +MODULES = bpf_testmod.ko bpf_test_no_cfi.ko
> >> +
> >> +$(foreach m,$(MODULES),$(eval obj-m += $(m:.ko=.o)))
> >> +
> >> +CFLAGS_bpf_testmod.o = -I$(src)
> >> +
> >> +all: modules.built
> >> +
> >> +modules.built: *.[ch]
> >
> > curious, the top Makefile already checks for test_kmods/*.[ch], do we
> > need *.[ch] ?
> 
> Not really for building from the top-level Makefile, that is for running
> 'make' inside the subdir, in case anyone tries that. Don't feel strongly
> about it, so can remove it if you prefer?

no strong feelings either ;-) I was just wondering what was the purpose

thanks,
jirka