netdev - Re: [RFC net-next v4 5/9] net: napi: Add napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241008151701.6f8bb389@kernel.org>
Date: Tue, 8 Oct 2024 15:17:01 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Joe Damato <jdamato@...tly.com>
Cc: netdev@...r.kernel.org, mkarsten@...terloo.ca, skhawaja@...gle.com,
 sdf@...ichev.me, bjorn@...osinc.com, amritha.nambiar@...el.com,
 sridhar.samudrala@...el.com, willemdebruijn.kernel@...il.com, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Jiri Pirko
 <jiri@...nulli.us>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Johannes Berg
 <johannes.berg@...el.com>, linux-doc@...r.kernel.org (open
 list:DOCUMENTATION), linux-kernel@...r.kernel.org (open list)
Subject: Re: [RFC net-next v4 5/9] net: napi: Add napi_config

On Tue,  1 Oct 2024 23:52:36 +0000 Joe Damato wrote:
>  static inline void netdev_set_defer_hard_irqs(struct net_device *netdev,
>  					      u32 defer)
>  {
> +	unsigned int count = max(netdev->num_rx_queues,
> +				 netdev->num_tx_queues);
>  	struct napi_struct *napi;
> +	int i;
>  
>  	WRITE_ONCE(netdev->napi_defer_hard_irqs, defer);
>  	list_for_each_entry(napi, &netdev->napi_list, dev_list)
>  		napi_set_defer_hard_irqs(napi, defer);
> +
> +	if (netdev->napi_config)

Could this ever be NULL ?

> +		for (i = 0; i < count; i++)
> +			netdev->napi_config[i].defer_hard_irqs = defer;
>  }