netdev - [PATCHv2 net] net: ibm: emac: mal: add dcr_unmap to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241008233050.9422-1-rosenp@gmail.com>
Date: Tue,  8 Oct 2024 16:30:50 -0700
From: Rosen Penev <rosenp@...il.com>
To: netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Rosen Penev <rosenp@...il.com>,
	Jeff Johnson <quic_jjohnson@...cinc.com>,
	Breno Leitao <leitao@...ian.org>,
	Christian Marangi <ansuelsmth@...il.com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	David Gibson <david@...son.dropbear.id.au>,
	Jeff Garzik <jeff@...zik.org>,
	linux-kernel@...r.kernel.org (open list)
Subject: [PATCHv2 net] net: ibm: emac: mal: add dcr_unmap to _remove

It's done in probe so it should be done here.

Fixes: 1d3bb996 ("Device tree aware EMAC driver")
Signed-off-by: Rosen Penev <rosenp@...il.com>
---
 v2: Rebase and add proper fixes line.
 drivers/net/ethernet/ibm/emac/mal.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/ibm/emac/mal.c b/drivers/net/ethernet/ibm/emac/mal.c
index a93423035325..c634534710d9 100644
--- a/drivers/net/ethernet/ibm/emac/mal.c
+++ b/drivers/net/ethernet/ibm/emac/mal.c
@@ -742,6 +742,8 @@ static void mal_remove(struct platform_device *ofdev)
 
 	free_netdev(mal->dummy_dev);
 
+	dcr_unmap(mal->dcr_host, 0x100);
+
 	dma_free_coherent(&ofdev->dev,
 			  sizeof(struct mal_descriptor) *
 			  (NUM_TX_BUFF * mal->num_tx_chans +
-- 
2.46.2