netdev - Re: [PATCH v6 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7383268f-4655-433a-9b9b-ebc9ac3d57ea@quicinc.com>
Date: Wed, 9 Oct 2024 13:09:27 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: <andersson@...nel.org>, <mturquette@...libre.com>, <sboyd@...nel.org>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <konradybcio@...nel.org>, <catalin.marinas@....com>, <will@...nel.org>,
        <p.zabel@...gutronix.de>, <richardcochran@...il.com>,
        <geert+renesas@...der.be>, <neil.armstrong@...aro.org>,
        <arnd@...db.de>, <nfraprado@...labora.com>, <quic_anusha@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>
Subject: Re: [PATCH v6 5/7] clk: qcom: Add NSS clock Controller driver for
 IPQ9574



On 10/7/2024 1:32 AM, Dmitry Baryshkov wrote:
> On Fri, Oct 04, 2024 at 01:33:30PM GMT, Manikanta Mylavarapu wrote:
>> From: Devi Priya <quic_devipriy@...cinc.com>
>>
>> Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based
>> devices.
>>
>> Signed-off-by: Devi Priya <quic_devipriy@...cinc.com>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> ---
>> Changes in V6:
>> 	- Remove 'nsscc_ipq9574_desc' and use 'nss_cc_ipq9574_desc' in
>> 	  probe()
>> 	- Drop of_clk_get() and clk_prepare_enable() in probe() because
>> 	  ethernet node will subscribe to GCC_NSSCC_CLK and enable it.
> 
> Does the cllock supply the clock controller? If not, it should be
> dropped from bindings too.
> 
Hi Dmitry,

Since GCC_NSSCC_CLK is the source for the NSS clock controller, there is no need to drop it from the bindings.

Thanks & Regards,
Manikanta.