netdev - Re: [PATCH net] pktgen: Avoid out-of-range in get_imix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241008182319.0a6fe8ad@kernel.org>
Date: Tue, 8 Oct 2024 18:23:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Artem Chernyshev <artem.chernyshev@...-soft.ru>
Cc: "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org
Subject: Re: [PATCH net] pktgen: Avoid out-of-range in get_imix_entries

On Mon,  7 Oct 2024 01:12:20 +0300 Artem Chernyshev wrote:
> In get_imit_enries() pkt_dev->n_imix_entries = MAX_IMIX_ENTRIES 
> leads to oob for pkt_dev->imix_entries array.

I don't think so, at least not exactly. It's legal to fill the array
completely. It's not legal to try to _add_ to an already full array.

AFAICT the fix needs more work.
-- 
pw-bot: cr