netdev - Re: [PATCH net] net/smc: fix lacks of icsk_syn_mss with IPPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLHwsKVQo_aVwVQAt3fpZ2E3SL3eM2-v+RacwbOdUqePg@mail.gmail.com>
Date: Wed, 9 Oct 2024 15:07:54 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: "D. Wythe" <alibuda@...ux.alibaba.com>
Cc: kgraul@...ux.ibm.com, wenjia@...ux.ibm.com, jaka@...ux.ibm.com, 
	wintera@...ux.ibm.com, guwen@...ux.alibaba.com, kuba@...nel.org, 
	davem@...emloft.net, netdev@...r.kernel.org, linux-s390@...r.kernel.org, 
	linux-rdma@...r.kernel.org, tonylu@...ux.alibaba.com, pabeni@...hat.com
Subject: Re: [PATCH net] net/smc: fix lacks of icsk_syn_mss with IPPROTO_SMC

On Wed, Oct 9, 2024 at 8:55 AM D. Wythe <alibuda@...ux.alibaba.com> wrote:
>
> From: "D. Wythe" <alibuda@...ux.alibaba.com>
>
> Eric report a panic on IPPROTO_SMC, and give the facts
> that when INET_PROTOSW_ICSK was set, icsk->icsk_sync_mss must be set too.
>
>

> This patch add a toy implementation that performs a simple return to
> prevent such panic. This is because MSS can be set in sock_create_kern
> or smc_setsockopt, similar to how it's done in AF_SMC. However, for
> AF_SMC, there is currently no way to synchronize MSS within
> __sys_connect_file. This toy implementation lays the groundwork for us
> to support such feature for IPPROTO_SMC in the future.
>
> Fixes: d25a92ccae6b ("net/smc: Introduce IPPROTO_SMC")
> Reported-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: D. Wythe <alibuda@...ux.alibaba.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>