netdev - Re: [PATCH net-next v4] eth: fbnic: Add hardware monitoring support via HWMON interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241009062653.79fb9c36@kernel.org>
Date: Wed, 9 Oct 2024 06:26:53 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Sanman Pradhan <sanman.p211993@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kernel-team@...a.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 jdelvare@...e.com, linux@...ck-us.net, horms@...nel.org,
 mohsin.bashr@...il.com, sanmanpradhan@...a.com, andrew@...n.ch,
 linux-hwmon@...r.kernel.org
Subject: Re: [PATCH net-next v4] eth: fbnic: Add hardware monitoring support
 via HWMON interface

On Tue,  8 Oct 2024 07:32:12 -0700 Sanman Pradhan wrote:
>  	if (!fbd->dsn) {
>  		dev_warn(&pdev->dev, "Reading serial number failed\n");
> -		goto init_failure_mode;
> +		goto hwmon_unregister;
>  	}
> 
>  	netdev = fbnic_netdev_alloc(fbd);
> @@ -310,6 +312,8 @@ static int fbnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> 
>  ifm_free_netdev:
>  	fbnic_netdev_free(fbd);
> +hwmon_unregister:
> +	fbnic_hwmon_unregister(fbd);

not what I meant...
Delete these two lines and leave the goto above as is.
HWMON can remain registered even if we don't probe networking.
-- 
pw-bot: cr