netdev - Re: [PATCH net-next v3 4/7] bnxt_en: add support for tcp-data-split-thresh ethtool command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTWxPASRynkB=JA7XJXcJ448-FiCc_H-DCN=3tm8k5DN4g@mail.gmail.com>
Date: Wed, 9 Oct 2024 23:31:10 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com, 
	almasrymina@...gle.com, netdev@...r.kernel.org, linux-doc@...r.kernel.org, 
	donald.hunter@...il.com, corbet@....net, michael.chan@...adcom.com, 
	kory.maincent@...tlin.com, andrew@...n.ch, maxime.chevallier@...tlin.com, 
	danieller@...dia.com, hengqi@...ux.alibaba.com, ecree.xilinx@...il.com, 
	przemyslaw.kitszel@...el.com, hkallweit1@...il.com, ahmed.zaki@...el.com, 
	paul.greenwalt@...el.com, rrameshbabu@...dia.com, idosch@...dia.com, 
	asml.silence@...il.com, kaiyuanz@...gle.com, willemb@...gle.com, 
	aleksander.lobakin@...el.com, dw@...idwei.uk, sridhar.samudrala@...el.com, 
	bcreeley@....com
Subject: Re: [PATCH net-next v3 4/7] bnxt_en: add support for
 tcp-data-split-thresh ethtool command

On Wed, Oct 9, 2024 at 3:35 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu,  3 Oct 2024 16:06:17 +0000 Taehee Yoo wrote:
> > +#define BNXT_HDS_THRESHOLD_MAX       256
> > +     u16                     hds_threshold;
>
> From the cover letter it sounded like the max is 1023.
> Did I misread that ?

Based on my test, the maximum value seems to be 1023.
But I'm not sure that all NICs, that use bnxt_en driver support 1023 value.
(At least all NICs I have support 1023).
I decided 256 as the maximum value, that was default value so all
NICs can use it safely. If Broadcom Engineer confirms 1023 is right
 for all NICs, I would like to change it.