netdev - RE: [PATCH v2 iwl-next 0/4] Fix E825 initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM4PR11MB61175C3E0CEE0E0FF7F84E51827F2@DM4PR11MB6117.namprd11.prod.outlook.com>
Date: Wed, 9 Oct 2024 14:48:56 +0000
From: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>
To: "Kolacinski, Karol" <karol.kolacinski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>
Subject: RE: [PATCH v2 iwl-next 0/4] Fix E825 initialization

> 
> E825 products have incorrect initialization procedure, which may lead to
> initialization failures and register values.
> 
> Fix E825 products initialization by adding correct sync delay, checking the
> PHY
> revision only for current PHY and adding proper destination device when
> reading
> port/quad.
> 
> In addition, E825 uses PF ID for indexing per PF registers and as a primary
> PHY
> lane number, which is incorrect.
> 
> 
> Karol Kolacinski (4):
>   ice: Fix E825 initialization
>   ice: Fix quad registers read on E825
>   ice: Fix ETH56G FC-FEC Rx offset value
>   ice: Add correct PHY lane assignment
> 
>  drivers/net/ethernet/intel/ice/ice_common.c   |  42 ++-
>  drivers/net/ethernet/intel/ice/ice_common.h   |   1 +
>  drivers/net/ethernet/intel/ice/ice_main.c     |   6 +-
>  drivers/net/ethernet/intel/ice/ice_ptp.c      |  23 +-
>  drivers/net/ethernet/intel/ice/ice_ptp.h      |   4 +-
>  .../net/ethernet/intel/ice/ice_ptp_consts.h   |  77 +----
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.c   | 285 +++++++++---------
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.h   |  40 ++-
>  drivers/net/ethernet/intel/ice/ice_sbq_cmd.h  |   7 +-
>  drivers/net/ethernet/intel/ice/ice_type.h     |   2 -
>  10 files changed, 243 insertions(+), 244 deletions(-)
> 
> V1 -> V2: Removed net-next hunks from "ice: Fix E825 initialization",
>           whole "ice: Remove unnecessary offset calculation for PF
>           scoped registers" patch and fixed kdoc in "ice: Fix quad
>           registers read on E825"

You forgot to s/next/net in patch subjects. This is supposed to
be routed via net tree AFAICS.

> 
> base-commit: af8cac359cecaab37a171039fc82cfd1f7aca501
> --
> 2.46.2
>