netdev - Re: [PATCH bpf 2/4] selftests/bpf: Consolidate kernel modules into common directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQKM0Mw=VXp6mX2aZrHoUz1+EpVO5RDMq3FPm9scPkVZXw@mail.gmail.com>
Date: Tue, 8 Oct 2024 19:08:56 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Toke Høiland-Jørgensen <toke@...hat.com>
Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	John Fastabend <john.fastabend@...il.com>, Andrii Nakryiko <andrii@...nel.org>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, KP Singh <kpsingh@...nel.org>, 
	Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, 
	Kumar Kartikeya Dwivedi <memxor@...il.com>, Simon Sundberg <simon.sundberg@....se>, bpf <bpf@...r.kernel.org>, 
	Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf 2/4] selftests/bpf: Consolidate kernel modules into
 common directory

On Tue, Oct 8, 2024 at 3:35 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> The selftests build two kernel modules (bpf_testmod.ko and
> bpf_test_no_cfi.ko) which use copy-pasted Makefile targets. This is a
> bit messy, and doesn't scale so well when we add more modules, so let's
> consolidate these rules into a single rule generated for each module
> name, and move the module sources into a single directory.
>
> To avoid parallel builds of the different modules stepping on each
> other's toes during the 'modpost' phase of the Kbuild 'make modules', we
> create a single target for all the defined modules, which contains the
> recursive 'make' call into the modules directory. The Makefile in the
> subdirectory building the modules is modified to also touch a
> 'modules.built' file, which we can add as a dependency on the top-level
> selftests Makefile, thus ensuring that the modules are always rebuilt if
> any of the dependencies in the selftests change.

Nice cleanup, but looks unrelated to the fix and hence
not a bpf material.
Why combine them?