netdev - Re: [PATCH net-next] tcp: move sysctl_tcp_l3mdev_accept to netns_ipv4_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b946bb4-4918-4072-9f6c-d7cfc96f1f48@kernel.org>
Date: Wed, 9 Oct 2024 09:12:59 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
 Wei Wang <weiwan@...gle.com>, Coco Li <lixiaoyan@...gle.com>
Subject: Re: [PATCH net-next] tcp: move sysctl_tcp_l3mdev_accept to
 netns_ipv4_read_rx

On 10/9/24 9:05 AM, Eric Dumazet wrote:
> sysctl_tcp_l3mdev_accept is read from TCP receive fast path from
> tcp_v6_early_demux(),
>  __inet6_lookup_established,
>   inet_request_bound_dev_if().
> 
> Move it to netns_ipv4_read_rx.
> 
> Remove the '#ifdef CONFIG_NET_L3_MASTER_DEV' that was guarding
> its definition.
> 
> Note this adds a hole of three bytes that could be filled later.
> 
> Fixes: 18fd64d25422 ("netns-ipv4: reorganize netns_ipv4 fast path variables")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Wei Wang <weiwan@...gle.com>
> Cc: Coco Li <lixiaoyan@...gle.com>
> ---
>  .../networking/net_cachelines/netns_ipv4_sysctl.rst          | 2 +-
>  include/net/netns/ipv4.h                                     | 5 ++---
>  net/core/net_namespace.c                                     | 4 +++-
>  3 files changed, 6 insertions(+), 5 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>