[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9a99bf9e-ea1b-4fab-8b50-a2bd8a320579@kernel.org>
Date: Thu, 10 Oct 2024 15:13:18 +0300
From: Roger Quadros <rogerq@...nel.org>
To: Simon Horman <horms@...nel.org>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Siddharth Vadapalli <s-vadapalli@...com>
Cc: Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
<morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
Kalesh AP <kalesh-anakkur.purayil@...adcom.com>, netdev@...r.kernel.org,
linux-omap@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH net-next v2 3/3] net: ethernet: ti: cpsw_ale: Remove
unused accessor functions
On 10/10/2024 14:04, Simon Horman wrote:
> W=1 builds flag that some accessor functions for ALE fields are unused.
>
> Address this by splitting up the macros used to define these
> accessors to allow only those that are used to be declared.
>
> The warnings are verbose, but for example, the mcast_state case is
> flagged by clang-18 as:
>
> .../cpsw_ale.c:220:1: warning: unused function 'cpsw_ale_get_mcast_state' [-Wunused-function]
> 220 | DEFINE_ALE_FIELD(mcast_state, 62, 2)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> .../cpsw_ale.c:145:19: note: expanded from macro 'DEFINE_ALE_FIELD'
> 145 | static inline int cpsw_ale_get_##name(u32 *ale_entry) \
> | ^~~~~~~~~~~~~~~~~~~
> <scratch space>:196:1: note: expanded from here
> 196 | cpsw_ale_get_mcast_state
> | ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Compile tested only.
> No functional change intended.
>
> Signed-off-by: Simon Horman <horms@...nel.org>
Reviewed-by: Roger Quadros <rogerq@...nel.org>
Powered by blists - more mailing lists