netdev - Re: [PATCH 1/4] xfrm: Add support for per cpu xfrm state handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410110224.x8I8OGK4-lkp@intel.com>
Date: Fri, 11 Oct 2024 02:22:01 +0800
From: kernel test robot <lkp@...el.com>
To: Steffen Klassert <steffen.klassert@...unet.com>,
	Tobias Brunner <tobias@...ongswan.org>,
	Antony Antony <antony.antony@...unet.com>,
	Daniel Xu <dxu@...uu.xyz>, Paul Wouters <paul@...ats.ca>,
	Simon Horman <horms@...nel.org>,
	Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev,
	Steffen Klassert <steffen.klassert@...unet.com>,
	devel@...ux-ipsec.org
Subject: Re: [PATCH 1/4] xfrm: Add support for per cpu xfrm state handling.

Hi Steffen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on klassert-ipsec-next/master]
[also build test WARNING on klassert-ipsec/master net/main net-next/main linus/master v6.12-rc2 next-20241010]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Steffen-Klassert/xfrm-Add-support-for-per-cpu-xfrm-state-handling/20241007-145514
base:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
patch link:    https://lore.kernel.org/r/20241007064453.2171933-2-steffen.klassert%40secunet.com
patch subject: [PATCH 1/4] xfrm: Add support for per cpu xfrm state handling.
config: x86_64-randconfig-161-20241010 (https://download.01.org/0day-ci/archive/20241011/202410110224.x8I8OGK4-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410110224.x8I8OGK4-lkp@intel.com/

New smatch warnings:
net/xfrm/xfrm_user.c:2550 xfrm_aevent_msgsize() warn: inconsistent indenting

Old smatch warnings:
net/xfrm/xfrm_user.c:912 xfrm_add_sa() warn: missing error code? 'err'
net/xfrm/xfrm_user.c:2128 xfrm_add_policy() warn: missing error code? 'err'
net/xfrm/xfrm_user.c:2895 xfrm_add_acquire() warn: missing error code 'err'

vim +2550 net/xfrm/xfrm_user.c

  2536	
  2537	static inline unsigned int xfrm_aevent_msgsize(struct xfrm_state *x)
  2538	{
  2539		unsigned int replay_size = x->replay_esn ?
  2540				      xfrm_replay_state_esn_len(x->replay_esn) :
  2541				      sizeof(struct xfrm_replay_state);
  2542	
  2543		return NLMSG_ALIGN(sizeof(struct xfrm_aevent_id))
  2544		       + nla_total_size(replay_size)
  2545		       + nla_total_size_64bit(sizeof(struct xfrm_lifetime_cur))
  2546		       + nla_total_size(sizeof(struct xfrm_mark))
  2547		       + nla_total_size(4) /* XFRM_AE_RTHR */
  2548		       + nla_total_size(4) /* XFRM_AE_ETHR */
  2549		       + nla_total_size(sizeof(x->dir)); /* XFRMA_SA_DIR */
> 2550		       + nla_total_size(4); /* XFRMA_SA_PCPU */
  2551	}
  2552	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki