netdev - Re: [net-next v5 9/9] mlx4: Add support for persistent NAPI config to RX CQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+187Yht9K-Vkg6j_qj9sFiK0jaGSxMDdYCAUZUtBgMOw@mail.gmail.com>
Date: Thu, 10 Oct 2024 06:28:59 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Joe Damato <jdamato@...tly.com>
Cc: netdev@...r.kernel.org, mkarsten@...terloo.ca, skhawaja@...gle.com, 
	sdf@...ichev.me, bjorn@...osinc.com, amritha.nambiar@...el.com, 
	sridhar.samudrala@...el.com, willemdebruijn.kernel@...il.com, 
	Tariq Toukan <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	"open list:MELLANOX MLX4 core VPI driver" <linux-rdma@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [net-next v5 9/9] mlx4: Add support for persistent NAPI config to
 RX CQs

On Wed, Oct 9, 2024 at 2:56 AM Joe Damato <jdamato@...tly.com> wrote:
>
> Use netif_napi_add_config to assign persistent per-NAPI config when
> initializing RX CQ NAPIs.
>
> Presently, struct napi_config only has support for two fields used for
> RX, so there is no need to support them with TX CQs, yet.
>
> Signed-off-by: Joe Damato <jdamato@...tly.com>
> ---

nit: technically, the napi_defer_hard_irqs could benefit TX completions as well.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>