netdev - Re: [Intel-wired-lan] [PATCH iwl-net v1 0/5] igc: PTM timeout fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwjvHhptaNBirnea@calimero.vinschen.de>
Date: Fri, 11 Oct 2024 11:25:50 +0200
From: Corinna Vinschen <vinschen@...hat.com>
To: christopher.s.hall@...el.com
Cc: intel-wired-lan@...ts.osuosl.org, david.zage@...el.com,
	vinicius.gomes@...el.com, netdev@...r.kernel.org,
	rodrigo.cadore@...coustics.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1 0/5] igc: PTM timeout fix

Hi Christopher,


are you planning a followup to this patch series any tinme soon?


Thanks,
Corinna



On Aug  6 17:30, christopher.s.hall@...el.com wrote:
> From: Christopher S M Hall <christopher.s.hall@...el.com>
> 
> There have been sporadic reports of PTM timeouts using i225/i226 devices
> 
> These timeouts have been root caused to:
> 
> 1) Manipulating the PTM status register while PTM is enabled and triggered
> 2) The hardware retrying too quickly when an inappropriate response is
>    received from the upstream device
> 
> The issue can be reproduced with the following:
> 
> $ sudo phc2sys -R 1000 -O 0 -i tsn0 -m
> 
> Note: 1000 Hz (-R 1000) is unrealistically large, but provides a way to
> quickly reproduce the issue.
> 
> PHC2SYS exits with:
> 
> "ioctl PTP_OFFSET_PRECISE: Connection timed out" when the PTM transaction
>   fails
> 
> Christopher S M Hall (5):
>   igc: Ensure the PTM cycle is reliably triggered
>   igc: Lengthen the hardware retry time to prevent timeouts
>   igc: Move ktime snapshot into PTM retry loop
>   igc: Reduce retry count to a more reasonable number
>   igc: Add lock preventing multiple simultaneous PTM transactions
> 
>  drivers/net/ethernet/intel/igc/igc.h         |   1 +
>  drivers/net/ethernet/intel/igc/igc_defines.h |   3 +-
>  drivers/net/ethernet/intel/igc/igc_ptp.c     | 100 +++++++++++--------
>  3 files changed, 63 insertions(+), 41 deletions(-)
> 
> -- 
> 2.34.1