netdev - Re: [PATCH net-next v3 2/2] net: phy: aquantia: allow forcing order of MDI pairs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <795c9b87-ecd5-4fa5-82ae-b88069cbaafb@lunn.ch>
Date: Fri, 11 Oct 2024 20:12:52 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jon Hunter <jonathanh@...dia.com>
Cc: Daniel Golle <daniel@...rotopia.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Christian Marangi <ansuelsmth@...il.com>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Robert Marko <robimarko@...il.com>,
	Paweł Owoc <frut3k7@...il.com>,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH net-next v3 2/2] net: phy: aquantia: allow forcing order
 of MDI pairs

> This change is breaking networking for one of our Tegra boards and on boot I
> am seeing ...
> 
>  tegra-mgbe 6800000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0
>  tegra-mgbe 6800000.ethernet eth0: __stmmac_open: Cannot attach to PHY
>  (error: -22)
> 
> The issue is that of_property_read_u32() does not return -ENOENT if the
> property is missing, it actually returns -EINVAL. See the description of
> of_property_read_variable_u32_array() which is called by
> of_property_read_u32().
> 
> Andrew, can we drop this change from -next until this is fixed?

If it is as simple as s/ENOENT/EINVAL we should just fix it, rather
than revert it.

	Andrew