netdev - RE: [PATCH net-next 07/11] PCI: Add NXP NETC vendor ID and device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510FFF6813E16B72C0A2BBE88792@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Fri, 11 Oct 2024 02:06:11 +0000
From: Wei Fang <wei.fang@....com>
To: Bjorn Helgaas <helgaas@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>, Claudiu
 Manoil <claudiu.manoil@....com>, Clark Wang <xiaoning.wang@....com>, Frank Li
	<frank.li@....com>, "christophe.leroy@...roup.eu"
	<christophe.leroy@...roup.eu>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>
Subject: RE: [PATCH net-next 07/11] PCI: Add NXP NETC vendor ID and device IDs

> -----Original Message-----
> From: Bjorn Helgaas <helgaas@...nel.org>
> Sent: 2024年10月11日 3:35
> To: Wei Fang <wei.fang@....com>
> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; robh@...nel.org; krzk+dt@...nel.org;
> conor+dt@...nel.org; Vladimir Oltean <vladimir.oltean@....com>; Claudiu
> Manoil <claudiu.manoil@....com>; Clark Wang <xiaoning.wang@....com>;
> Frank Li <frank.li@....com>; christophe.leroy@...roup.eu;
> linux@...linux.org.uk; bhelgaas@...gle.com; imx@...ts.linux.dev;
> netdev@...r.kernel.org; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-pci@...r.kernel.org
> Subject: Re: [PATCH net-next 07/11] PCI: Add NXP NETC vendor ID and device
> IDs
> 
> On Wed, Oct 09, 2024 at 05:51:12PM +0800, Wei Fang wrote:
> > NXP NETC is a multi-function PCIe Root Complex Integrated Endpoint
> > (RCiEP) and it contains multiple PCIe functions, such as EMDIO,
> > PTP Timer, ENETC PF and VF. Therefore, add these device IDs to
> > pci_ids.h
> >
> > Signed-off-by: Wei Fang <wei.fang@....com>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> OK as-is, but if you have occasion to update this series for other
> reasons:
> 
>   - Slightly redundant to say "multi-function RCiEP ... contains
>     multiple functions".
> 
>   - Mention the drivers that will use these symbols in this commit log
>     so it's obvious that they're used in multiple places.
> 
>   - Wrap the commit log to fill 75 columns.
> 

Sure, thanks.

> > ---
> >  include/linux/pci_ids.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index 4cf6aaed5f35..acd7ae774913 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -1556,6 +1556,13 @@
> >  #define PCI_DEVICE_ID_PHILIPS_SAA7146	0x7146
> >  #define PCI_DEVICE_ID_PHILIPS_SAA9730	0x9730
> >
> > +/* NXP has two vendor IDs, the other one is 0x1957 */
> > +#define PCI_VENDOR_ID_NXP2		PCI_VENDOR_ID_PHILIPS
> > +#define PCI_DEVICE_ID_NXP2_ENETC_PF	0xe101
> > +#define PCI_DEVICE_ID_NXP2_NETC_EMDIO	0xee00
> > +#define PCI_DEVICE_ID_NXP2_NETC_TIMER	0xee02
> > +#define PCI_DEVICE_ID_NXP2_ENETC_VF	0xef00
> > +
> >  #define PCI_VENDOR_ID_EICON		0x1133
> >  #define PCI_DEVICE_ID_EICON_DIVA20	0xe002
> >  #define PCI_DEVICE_ID_EICON_DIVA20_U	0xe004
> > --
> > 2.34.1
> >