netdev - RE: [PATCH net-next] net: gianfar: Use __be64 * to store pointers to big endian values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB8849ED31BB74E4FD193AB26396792@AS8PR04MB8849.eurprd04.prod.outlook.com>
Date: Fri, 11 Oct 2024 22:01:30 +0000
From: Claudiu Manoil <claudiu.manoil@....com>
To: Simon Horman <horms@...nel.org>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] net: gianfar: Use __be64 * to store pointers to
 big endian values

> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Friday, October 11, 2024 12:20 PM
> To: Claudiu Manoil <claudiu.manoil@....com>
> Cc: David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; netdev@...r.kernel.org
> Subject: [PATCH net-next] net: gianfar: Use __be64 * to store pointers to big
> endian values
> 
> Timestamp values are read using pointers to 64-bit big endian values.
> But the type of these pointers is u64 *, host byte order.
> Use __be64 * instead.
> 
> Flagged by Sparse:
> 
> .../gianfar.c:2212:60: warning: cast to restricted __be64
> .../gianfar.c:2475:53: warning: cast to restricted __be64
> 
> Introduced by
> commit cc772ab7cdca ("gianfar: Add hardware RX timestamping support").
> 
> Compile tested only.
> No functional change intended.
> 
> Signed-off-by: Simon Horman <horms@...nel.org>

Reviewed-by: Claudiu Manoil <claudiu.manoil@....com>