netdev - Re: [PATCH] libceph: Remove crush deadcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241012133223.GJ77519@kernel.org>
Date: Sat, 12 Oct 2024 14:32:23 +0100
From: Simon Horman <horms@...nel.org>
To: linux@...blig.org
Cc: idryomov@...il.com, xiubli@...hat.com, ceph-devel@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libceph: Remove crush deadcode

On Fri, Oct 11, 2024 at 11:47:36PM +0100, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> crush_bucket_alg_name(), crush_get_bucket_item_weight(), crush_hash32(),
> and crush_hash32_5() were added by commit
> 5ecc0a0f8128 ("ceph: CRUSH mapping algorithm")
> in 2009 but never used.
> 
> crush_hash_name() was added a little later by commit
> fb690390e305 ("ceph: make CRUSH hash function a bucket property")
> and also not used.
> 
> Remove them.
> 
> They called a couple of static functions crush_hash32_rjenkins1()
> and crush_hash32_rjenkins1_5() which are now unused.
> 
> Also remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Reviewed-by: Simon Horman <horms@...nel.org>