netdev - Questions about XDP hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <90c1c6b53a654cf197eb412917fad31a@huawei.com>
Date: Sat, 12 Oct 2024 09:12:12 +0000
From: tianmuyang <tianmuyang@...wei.com>
To: "bpf@...r.kernel.org" <bpf@...r.kernel.org>
CC: "larysa.zaremba@...el.com" <larysa.zaremba@...el.com>, "ast@...nel.org"
	<ast@...nel.org>, "daniel@...earbox.net" <daniel@...earbox.net>,
	"andrii@...nel.org" <andrii@...nel.org>, "martin.lau@...ux.dev"
	<martin.lau@...ux.dev>, "song@...nel.org" <song@...nel.org>, "yhs@...com"
	<yhs@...com>, "john.fastabend@...il.com" <john.fastabend@...il.com>,
	"kpsingh@...nel.org" <kpsingh@...nel.org>, "sdf@...gle.com" <sdf@...gle.com>,
	"haoluo@...gle.com" <haoluo@...gle.com>, "jolsa@...nel.org"
	<jolsa@...nel.org>, "dsahern@...il.com" <dsahern@...il.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "willemb@...gle.com"
	<willemb@...gle.com>, "brouer@...hat.com" <brouer@...hat.com>,
	"anatoly.burakov@...el.com" <anatoly.burakov@...el.com>,
	"alexandr.lobakin@...el.com" <alexandr.lobakin@...el.com>,
	"magnus.karlsson@...il.com" <magnus.karlsson@...il.com>, "mtahhan@...hat.com"
	<mtahhan@...hat.com>, "xdp-hints@...-project.net"
	<xdp-hints@...-project.net>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "willemdebruijn.kernel@...il.com"
	<willemdebruijn.kernel@...il.com>, "alexei.starovoitov@...il.com"
	<alexei.starovoitov@...il.com>, "simon.horman@...igine.com"
	<simon.horman@...igine.com>, "Yanan (Euler)" <yanan@...wei.com>, "Wuchangye
 (EulerOS)" <wuchangye@...wei.com>, Xiesongyang <xiesongyang@...wei.com>,
	"Liuxin(EulerOS)" <liuxin350@...wei.com>, "zhangmingyi (C)"
	<zhangmingyi5@...wei.com>, "liwei (H)" <liwei883@...wei.com>, tianmuyang
	<tianmuyang@...wei.com>
Subject: Questions about XDP hints

Hi all:
	There has been some discussions about adding checksum hint in AF_XDP such as this thread[1]. Now, we also plan to add checksum hint. My questions are:
	1. In this msg[2], is it appropriate if xdp_csum_status only includes 4 enums/macros(CHECKSUM_NONE...CHECKSUM_PARTIAL in skbuff.h)? Thus it becomes more generic. Also, in this msg[3] we can simply pass skb->ip_summed to csum_status in veth_xdp_rx_csum().
	2. What should be taken care of if I want to add a new hint? IOW, what is acceptable to add a new hint?

Thanks!

[1] https://lore.kernel.org/bpf/CAADnVQJPgpo7J0qVTQJYYocZ=Jnw=O5GfN2=PyAQ55+WWG_DVg@mail.gmail.com/
[2] https://lore.kernel.org/bpf/20230728173923.1318596-13-larysa.zaremba@intel.com/
[3] https://lore.kernel.org/bpf/20230728173923.1318596-18-larysa.zaremba@intel.com/