[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZwvIfwUv3hmKyW60@shredder.mtl.com>
Date: Sun, 13 Oct 2024 16:17:51 +0300
From: Ido Schimmel <idosch@...dia.com>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: kuba@...nel.org, aleksander.lobakin@...el.com, horms@...nel.org,
davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
dsahern@...nel.org, dongml2@...natelecom.cn, amcohen@...dia.com,
gnault@...hat.com, bpoirier@...dia.com, b.galvani@...il.com,
razor@...ckwall.org, petrm@...dia.com, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next v7 09/12] net: vxlan: add drop reasons support
to vxlan_xmit_one()
On Wed, Oct 09, 2024 at 10:28:27AM +0800, Menglong Dong wrote:
> Replace kfree_skb/dev_kfree_skb with kfree_skb_reason in vxlan_xmit_one.
> No drop reasons are introduced in this commit.
>
> The only concern of mine is replacing dev_kfree_skb with
> kfree_skb_reason. The dev_kfree_skb is equal to consume_skb, and I'm not
> sure if we can change it to kfree_skb here. In my option, the skb is
> "dropped" here, isn't it?
>
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>
> Reviewed-by: Simon Horman <horms@...nel.org>
Reviewed-by: Ido Schimmel <idosch@...dia.com>
Powered by blists - more mailing lists