netdev - Re: [RFC PATCH net-next] net: dsa: vsc73xx: remove ds->untag_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241014145529.zyki6k6yuob4nyop@skbuf>
Date: Mon, 14 Oct 2024 17:55:29 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Paweł Dembicki <paweldembicki@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH net-next] net: dsa: vsc73xx: remove
 ds->untag_bridge_pvid request

On Sat, Oct 12, 2024 at 10:23:35PM +0200, Paweł Dembicki wrote:
> wt., 8 paź 2024 o 12:47 Vladimir Oltean <vladimir.oltean@....com> napisał(a):
> >
> > Similar to the situation described for sja1105 in commit 1f9fc48fd302
> > ("net: dsa: sja1105: fix reception from VLAN-unaware bridges") from the
> > 'net' tree, the vsc73xx driver uses tag_8021q.
> >
> > The ds->untag_bridge_pvid option strips VLANs from packets received on
> > VLAN-unaware bridge ports. But those VLANs should already be stripped by
> > tag_vsc73xx_8021q.c as part of vsc73xx_rcv(). It is even plausible that
> > the same bug that existed for sja1105 also exists for vsc73xx:
> > dsa_software_untag_vlan_unaware_bridge() tries to untag a VLAN that
> > doesn't exist, corrupting the packet.
> >
> > Only compile tested, as I don't have access to the hardware.
> >
> 
> Thanks Vladimir for this patch. This fix is required for the proper
> functioning of vsc73xx.
> 
> Tested-by: Pawel Dembicki <paweldembicki@...il.com>

Thanks for testing, Paweł, I suspected as much. I will resend a v2 to
the 'net' tree with your test tag and a Fixes: tag. I hope I caught it
early enough that it didn't cause too much trouble.