netdev - Re: [PATCH][v2] net/smc: Fix searching in list of known pnetids in smc_pnet_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6718bb940436d7ca154c6c63b7809495210eef4.camel@linux.ibm.com>
Date: Mon, 14 Oct 2024 17:06:30 +0200
From: Gerd Bayer <gbayer@...ux.ibm.com>
To: Li RongQing <lirongqing@...du.com>, netdev@...r.kernel.org
Subject: Re: [PATCH][v2] net/smc: Fix searching in list of known pnetids in
 smc_pnet_add_pnetid

On Mon, 2024-10-14 at 19:53 +0800, Li RongQing wrote:
> pnetid of pi (not newly allocated pe) should be compared
> 
> Fixes: e888a2e8337c ("net/smc: introduce list of pnetids for Ethernet
> devices")
> Reviewed-by: D. Wythe <alibuda@...ux.alibaba.com>
> Reviewed-by: Wen Gu <guwen@...ux.alibaba.com>
> Signed-off-by: Li RongQing <lirongqing@...du.com>
> ---
> Diff with v1: change commit header as Gerd Bayer suggested
> Sorry for not CC all maintainers, since this patch was rejected by
> netdev twice
> 
>  net/smc/smc_pnet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c
> index 1dd3623..a04aa0e 100644
> --- a/net/smc/smc_pnet.c
> +++ b/net/smc/smc_pnet.c
> @@ -753,7 +753,7 @@ static int smc_pnet_add_pnetid(struct net *net,
> u8 *pnetid)
>  
>  	write_lock(&sn->pnetids_ndev.lock);
>  	list_for_each_entry(pi, &sn->pnetids_ndev.list, list) {
> -		if (smc_pnet_match(pnetid, pe->pnetid)) {
> +		if (smc_pnet_match(pnetid, pi->pnetid)) {
>  			refcount_inc(&pi->refcnt);
>  			kfree(pe);
>  			goto unlock;

Thanks for adapting the subject!
Reviewed-by: Gerd Bayer <gbayer@...ux.ibm.com>