netdev - Re: [PATCH net-next v3] r8169: use the extended tally counter available from RTL8125

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23e91c3c-295a-4a9d-9165-3acaaf793611@gmail.com>
Date: Mon, 14 Oct 2024 22:48:27 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Realtek linux nic maintainers <nic_swsd@...ltek.com>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>,
 Paolo Abeni <pabeni@...hat.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3] r8169: use the extended tally counter
 available from RTL8125

On 12.10.2024 00:58, Jakub Kicinski wrote:
> On Fri, 11 Oct 2024 14:40:58 +0200 Heiner Kallweit wrote:
>> +static const char rtl8125_gstrings[][ETH_GSTRING_LEN] = {
>> +	"tx_bytes",
>> +	"rx_bytes",
> 
> these I presume are covered by @get_eth_mac_stats ?
> 
>> +	"tx_pause_on",
>> +	"tx_pause_off",
>> +	"rx_pause_on",
>> +	"rx_pause_off",
> 
> and if you want to add custom pause string you should first
> implement @get_pause_stats

Please disregard this patch. Its successor is "r8169: implement
additional ethtool stats ops". I didn't make this a new version
of the original patch because the scope is quite different.