netdev - Re: [PATCH v2 net] net: dsa: mv88e6xxx: Fix the max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcf3614c-1347-4594-9073-779b45f7bb7f@lunn.ch>
Date: Mon, 14 Oct 2024 22:57:59 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Peter Rashleigh <peter@...hleigh.ca>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] net: dsa: mv88e6xxx: Fix the max_vid definition
 for the MV88E6361

On Mon, Oct 14, 2024 at 01:43:42PM -0700, Peter Rashleigh wrote:
> According to the Marvell datasheet the 88E6361 has two VTU pages
> (4k VIDs per page) so the max_vid should be 8191, not 4095.
> 
> In the current implementation mv88e6xxx_vtu_walk() gives unexpected
> results because of this error. I verified that mv88e6xxx_vtu_walk()
> works correctly on the MV88E6361 with this patch in place.
> 
> Fixes: 12899f299803 ("net: dsa: mv88e6xxx: enable support for 88E6361 switch")
> Signed-off-by: Peter Rashleigh <peter@...hleigh.ca>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew