netdev - Re: [PATCH] net/smc: fix wrong comparation in smc_pnet_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ed7e21875ae766e751cafe9635f3fe49d4c933d.camel@linux.ibm.com>
Date: Mon, 14 Oct 2024 08:43:37 +0200
From: Gerd Bayer <gbayer@...ux.ibm.com>
To: "D. Wythe" <alibuda@...ux.alibaba.com>,
        Li RongQing
 <lirongqing@...du.com>, wenjia@...ux.ibm.com,
        jaka@...ux.ibm.com, tonylu@...ux.alibaba.com, guwen@...ux.alibaba.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, ubraun@...ux.ibm.com, kgraul@...ux.ibm.com,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net/smc: fix wrong comparation in smc_pnet_add_pnetid

Hi Li RongQing,

On Mon, 2024-10-14 at 13:41 +0800, D. Wythe wrote:
> On 10/11/24 2:19 PM, Li RongQing wrote:
> > pnetid of pi (not newly allocated pe) should be compared
> > 
> > Fixes: e888a2e8337c ("net/smc: introduce list of pnetids for
> > Ethernet devices")
> > Signed-off-by: Li RongQing <lirongqing@...du.com>
> > ---
> >   net/smc/smc_pnet.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c
> > index 1dd3623..a04aa0e 100644
> > --- a/net/smc/smc_pnet.c
> > +++ b/net/smc/smc_pnet.c
> > @@ -753,7 +753,7 @@ static int smc_pnet_add_pnetid(struct net *net,
> > u8 *pnetid)
> >   
> >   	write_lock(&sn->pnetids_ndev.lock);
> >   	list_for_each_entry(pi, &sn->pnetids_ndev.list, list) {
> > -		if (smc_pnet_match(pnetid, pe->pnetid)) {
> > +		if (smc_pnet_match(pnetid, pi->pnetid)) {
> >   			refcount_inc(&pi->refcnt);
> >   			kfree(pe);
> >   			goto unlock;
> 
> Reviewed-by: D. Wythe <alibuda@...ux.alibaba.com>
> 
> Thanks,
> D. Wythe
> 

Good catch, indeed!

Is this intentionally discussed off-list?
For consideration by netdev maintainers this will have to be re-
submitted with a [PATCH net] prefix to the netdev mailing list.

Also, I'd prefer, if you could find a more descriptive subject. How
about: "Fix search in list of known pnetids"? However, if you want to
keep the subject please replace "comparation" with "comparison"

Thank you,
Gerd Bayer