netdev - Re: [PATCH net-next 04/10] selftests: RED: Use defer for test cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y12phh1c.fsf@nvidia.com>
Date: Tue, 15 Oct 2024 11:03:39 +0200
From: Petr Machata <petrm@...dia.com>
To: Paolo Abeni <pabeni@...hat.com>
CC: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	<netdev@...r.kernel.org>, <linux-kselftest@...r.kernel.org>, Shuah Khan
	<shuah@...nel.org>, Benjamin Poirier <bpoirier@...dia.com>, Hangbin Liu
	<liuhangbin@...il.com>, Vladimir Oltean <vladimir.oltean@....com>, "Ido
 Schimmel" <idosch@...dia.com>, Przemek Kitszel
	<przemyslaw.kitszel@...el.com>, <mlxsw@...dia.com>
Subject: Re: [PATCH net-next 04/10] selftests: RED: Use defer for test cleanup


Paolo Abeni <pabeni@...hat.com> writes:

> On 10/9/24 14:06, Petr Machata wrote:
>> @@ -450,6 +415,7 @@ __do_ecn_test()
>>     	start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) \
>>   			  $h3_mac tos=0x01
>> +	defer stop_traffic $!
>>   	sleep 1
>>     	ecn_test_common "$name" "$get_nmarked" $vlan $limit
>> @@ -462,7 +428,6 @@ __do_ecn_test()
>>   	check_fail $? "UDP traffic went into backlog instead of being early-dropped"
>>   	log_test "TC $((vlan - 10)): $name backlog > limit: UDP early-dropped"
>>   -	stop_traffic
>>   	sleep 1
>
> I'm wodering what role/goal has the above 'sleep 1'?!? It looks like it could/should be removed
> after moving the stop_traffic call to the deferred cleanup.

Yeah, I'll drop these for v2.