netdev - Re: [PATCH RFC v1 net-next 00/12] bridge-fastpath and related improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b0a92f2-2e80-429c-8fcd-d4dc162e6e1f@nbd.name>
Date: Tue, 15 Oct 2024 14:16:45 +0200
From: Felix Fietkau <nbd@....name>
To: Eric Woudstra <ericwouds@...il.com>,
 Nikolay Aleksandrov <razor@...ckwall.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Pablo Neira Ayuso <pablo@...filter.org>,
 Jozsef Kadlecsik <kadlec@...filter.org>, Roopa Prabhu <roopa@...dia.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Jiri Pirko <jiri@...nulli.us>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Lorenzo Bianconi <lorenzo@...nel.org>,
 Frank Wunderlich <frank-w@...lic-files.de>,
 Daniel Golle <daniel@...rotopia.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 netfilter-devel@...r.kernel.org, coreteam@...filter.org,
 bridge@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH RFC v1 net-next 00/12] bridge-fastpath and related
 improvements

Hi Eric,

On 14.10.24 20:29, Eric Woudstra wrote:
> It would be no problem for me to change the subject and body, if you
> think that is better.
> 
> The thing is, these patches actually make it possible to set up a fully
> functional software fastpath between bridged interfaces. Only after the
> software fastpath is set up and functional, it can be offloaded, which
> happens to by my personal motivation to write this patch-set.
> 
> If the offload flag is set in the flowtable, the software fastpath will
> be offloaded. But in this patch-set, there is nothing that changes
> anything there, the existing code is used unchanged.

FWIW, a while back, I also wanted to add a software fast path for the 
bridge layer to the kernel, also with the intention of using it for 
hardware offload. It wasn't accepted back then, because (if I remember 
correctly) people didn't want any extra complexity in the network stack 
to make the bridge layer faster.

Because of that, I created this piece of software:
https://github.com/nbd168/bridger

It uses an eBPF TC classifier for discovering flows and handling the 
software fast path, and also creates hardware offload rules for flows.
With that, hardware offloading for bridged LAN->WLAN flows is fully 
supported on MediaTek hardware with upstream kernels.

- Felix