netdev - [net-next PATCH v2 00/10] Extend GbEth checksum offload support to VLAN/IPv6 packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241015133634.193-1-paul.barker.ct@bp.renesas.com>
Date: Tue, 15 Oct 2024 14:36:24 +0100
From: Paul Barker <paul.barker.ct@...renesas.com>
To: Sergey Shtylyov <s.shtylyov@....ru>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>
Cc: Paul Barker <paul.barker.ct@...renesas.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
	Biju Das <biju.das.jz@...renesas.com>,
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
	netdev@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [net-next PATCH v2 00/10] Extend GbEth checksum offload support to VLAN/IPv6 packets

The GbEth IP found in Renesas RZ/G2L, RZ/G3S and related SoCs supports
hardware checksum offload for packets in the following cases:

 - there are zero or one VLAN headers with TPID=0x8100
 - the network protocol is IPv4 or IPv6
 - the transport protocol is TCP, UDP or ICMP
 - the packet is not fragmented 

To complete the support for all these cases in the ravb driver, we need
to add handling for VLAN-tagged packets and IPv6 packets in both the TX
and RX code paths. Handling for ICMP packets in the TX path is not added
as it cannot currently be tested.

These patches also do some refactoring/tidy-up, drop unnecessary checks
from performance sensitive code paths and disable unnecessary IP header
checksum offloading.

Changes v1->v2:
  - Use get_unaligned() to access hw_csum in ravb_rx_csum_gbeth().
  - Dropped patch "Support ICMP TX checksum offload for GbEth" and
    simplified TX checksum offload path.
  - Moved last_frag into if condition in ravb_can_tx_csum_gbeth().
  - Dropped unnecessary check for skb->vlan_proto in
    ravb_can_tx_csum_gbeth().
  - s/HW/hardware/ in "Simplify types in RX csum validation" commit
    message.
  - s/null/zero/ in "Simplify UDP TX checksum offload" commit message.
  - Specified TX/RX direction in "Enable IPv6 TX/RX checksum offloading
    for GbEth" commit messages.
  - Dropped unnecessary whitespace.
  - Added Sergey's Reviewed-by tags.

Paul Barker (10):
  net: ravb: Factor out checksum offload enable bits
  net: ravb: Disable IP header RX checksum offloading
  net: ravb: Drop IP protocol check from RX csum verification
  net: ravb: Combine if conditions in RX csum validation
  net: ravb: Simplify types in RX csum validation
  net: ravb: Disable IP header TX checksum offloading
  net: ravb: Simplify UDP TX checksum offload
  net: ravb: Enable IPv6 RX checksum offloading for GbEth
  net: ravb: Enable IPv6 TX checksum offload for GbEth
  net: ravb: Add VLAN checksum support

 drivers/net/ethernet/renesas/ravb.h      |   6 ++
 drivers/net/ethernet/renesas/ravb_main.c | 101 ++++++++++++-----------
 2 files changed, 61 insertions(+), 46 deletions(-)

-- 
2.43.0