netdev - [PATCH] net: plip: fix break; causing plip to never transmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241015-net-plip-tx-fix-v1-1-32d8be1c7e0b@gmail.com>
Date: Tue, 15 Oct 2024 17:16:04 +0200
From: Jakub Boehm via B4 Relay <devnull+boehm.jakub.gmail.com@...nel.org>
To: "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, Nathan Chancellor <nathan@...nel.org>, 
 Nick Desaulniers <ndesaulniers@...gle.com>, 
 Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, 
 "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
 llvm@...ts.linux.dev, Jakub Boehm <boehm.jakub@...il.com>
Subject: [PATCH] net: plip: fix break; causing plip to never transmit

From: Jakub Boehm <boehm.jakub@...il.com>

Since commit
  71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")

plip was not able to send any packets, this patch replaces one
unintended break; with fallthrough; which was originally missed by
commit 9525d69a3667 ("net: plip: mark expected switch fall-throughs").

I have verified with a real hardware PLIP connection that everything
works once again after applying this patch.

Fixes: 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
Signed-off-by: Jakub Boehm <boehm.jakub@...il.com>
---
 drivers/net/plip/plip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
index e39bfaefe8c50ba72238d04f08deaa46ca650c70..d81163bc910a3bcaa770a10c0e2d7d9b334a381b 100644
--- a/drivers/net/plip/plip.c
+++ b/drivers/net/plip/plip.c
@@ -815,7 +815,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
 				return HS_TIMEOUT;
 			}
 		}
-		break;
+		fallthrough;

 	case PLIP_PK_LENGTH_LSB:
 		if (plip_send(nibble_timeout, dev,

---
base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354
change-id: 20241015-net-plip-tx-fix-822e94e58a6e

Best regards,
-- 
Jakub Boehm <boehm.jakub@...il.com>