netdev - Re: [net-next PATCH v2 05/10] net: ravb: Simplify types in RX csum validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1412e549-607b-46d1-9f75-40eb8d0b1eb6@omp.ru>
Date: Tue, 15 Oct 2024 18:23:14 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Paul Barker <paul.barker.ct@...renesas.com>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Geert Uytterhoeven <geert+renesas@...der.be>,
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
	Biju Das <biju.das.jz@...renesas.com>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, <netdev@...r.kernel.org>,
	<linux-renesas-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [net-next PATCH v2 05/10] net: ravb: Simplify types in RX csum
 validation

On 10/15/24 4:36 PM, Paul Barker wrote:

> The hardware checksum value is used as a 16-bit flag, it is zero when
> the checksum has been validated and non-zero otherwise. Therefore we
> don't need to treat this as an actual __wsum type or call csum_unfold(),
> we can just use a u16 pointer.
> 
> Signed-off-by: Paul Barker <paul.barker.ct@...renesas.com>
[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

MBR, Sergey