netdev - Re: [PATCH v2 net] netdevsim: use cond_resched() in nsim_dev_trap_report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172901223025.1230547.4087935484646595253.git-patchwork-notify@kernel.org>
Date: Tue, 15 Oct 2024 17:10:30 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org, eric.dumazet@...il.com,
 syzbot+d383dc9579a76f56c251@...kaller.appspotmail.com,
 syzbot+c596faae21a68bf7afd0@...kaller.appspotmail.com, jiri@...dia.com
Subject: Re: [PATCH v2 net] netdevsim: use cond_resched() in
 nsim_dev_trap_report_work()

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Sat, 12 Oct 2024 09:42:30 +0000 you wrote:
> I am still seeing many syzbot reports hinting that syzbot
> might fool nsim_dev_trap_report_work() with hundreds of ports [1]
> 
> Lets use cond_resched(), and system_unbound_wq
> instead of implicit system_wq.
> 
> [1]
> INFO: task syz-executor:20633 blocked for more than 143 seconds.
>       Not tainted 6.12.0-rc2-syzkaller-00205-g1d227fcc7222 #0
> "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> task:syz-executor    state:D stack:25856 pid:20633 tgid:20633 ppid:1      flags:0x00004006
> ...
> NMI backtrace for cpu 1
> CPU: 1 UID: 0 PID: 16760 Comm: kworker/1:0 Not tainted 6.12.0-rc2-syzkaller-00205-g1d227fcc7222 #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
> Workqueue: events nsim_dev_trap_report_work
>  RIP: 0010:__sanitizer_cov_trace_pc+0x0/0x70 kernel/kcov.c:210
> Code: 89 fb e8 23 00 00 00 48 8b 3d 04 fb 9c 0c 48 89 de 5b e9 c3 c7 5d 00 0f 1f 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 <f3> 0f 1e fa 48 8b 04 24 65 48 8b 0c 25 c0 d7 03 00 65 8b 15 60 f0
> RSP: 0018:ffffc90000a187e8 EFLAGS: 00000246
> RAX: 0000000000000100 RBX: ffffc90000a188e0 RCX: ffff888027d3bc00
> RDX: ffff888027d3bc00 RSI: 0000000000000000 RDI: 0000000000000000
> RBP: ffff88804a2e6000 R08: ffffffff8a4bc495 R09: ffffffff89da3577
> R10: 0000000000000004 R11: ffffffff8a4bc2b0 R12: dffffc0000000000
> R13: ffff88806573b503 R14: dffffc0000000000 R15: ffff8880663cca00
> FS:  0000000000000000(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000
> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007fc90a747f98 CR3: 000000000e734000 CR4: 00000000003526f0
> DR0: 0000000000000000 DR1: 000000000000002b DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> Call Trace:
>  <NMI>
>  </NMI>
>  <TASK>
>   __local_bh_enable_ip+0x1bb/0x200 kernel/softirq.c:382
>   spin_unlock_bh include/linux/spinlock.h:396 [inline]
>   nsim_dev_trap_report drivers/net/netdevsim/dev.c:820 [inline]
>   nsim_dev_trap_report_work+0x75d/0xaa0 drivers/net/netdevsim/dev.c:850
>   process_one_work kernel/workqueue.c:3229 [inline]
>   process_scheduled_works+0xa63/0x1850 kernel/workqueue.c:3310
>   worker_thread+0x870/0xd30 kernel/workqueue.c:3391
>   kthread+0x2f0/0x390 kernel/kthread.c:389
>   ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
>   ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
>  </TASK>
> 
> [...]

Here is the summary with links:
  - [v2,net] netdevsim: use cond_resched() in nsim_dev_trap_report_work()
    https://git.kernel.org/netdev/net/c/a1494d532e28

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html