netdev - Re: [PATCH v2 net] net: systemport: fix potential memory leak in bcm_sysport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241015110315.656f5f03@kernel.org>
Date: Tue, 15 Oct 2024 11:03:15 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Wang Hai <wanghai38@...wei.com>
Cc: <florian.fainelli@...adcom.com>,
 <bcm-kernel-feedback-list@...adcom.com>, <davem@...emloft.net>,
 <edumazet@...gle.com>, <pabeni@...hat.com>, <zhangxiaoxu5@...wei.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 net] net: systemport: fix potential memory leak in
 bcm_sysport_xmit()

On Tue, 15 Oct 2024 22:35:58 +0800 Wang Hai wrote:
> The bcm_sysport_xmit() returns NETDEV_TX_OK without freeing skb
> in case of dma_map_single() fails, add dev_consume_skb_any() to fix it.

Technically you posted it 16min too early (23h 44min) and I'm not sure
this is better than v1, see the discussion there. So I'm discarding
this version.